stevelorddremio commented on PR #41237: URL: https://github.com/apache/arrow/pull/41237#issuecomment-2103611469
Thank you @mateuszrzeszutek. I have merged your changes to my PR. That looks to successfully run. On Wed, May 8, 2024 at 9:48 AM Mateusz Rzeszutek ***@***.***> wrote: > It looks like the ObjectPool created in FlightSqlExample's constructor and > the dataSource are also never closed. FlightSqlExample should override > close() to clean these up... > > It looks like the data source (and the object pool along with it) is being > closed properly though: > > https://github.com/apache/arrow/blob/304650145689291eb87db5dd58f7b9776bdfaacf/java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/FlightSqlExample.java#L759-L767 > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow/pull/41237#issuecomment-2101000037>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ARJIX7GO2L372XBYQ3POVK3ZBJJOJAVCNFSM6AAAAABGKCCSFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGAYDAMBTG4> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
