stevelorddremio commented on PR #41237: URL: https://github.com/apache/arrow/pull/41237#issuecomment-2112996902
Hello all, I am still getting an error message in TestFlightSqlStateless, but not in TestFlightSql that runs just before in the GitHub Actions Windows run. I'm thinking I need to remove the database as part of the tearDown() method in TestFlightSql. Would be grateful if anyone has other ideas I didn't consider. Error: org.apache.arrow.flight.sql.test.TestFlightSqlStateless -- Time elapsed: 0.015 s <<< ERROR! 3054 <https://github.com/apache/arrow/actions/runs/9025730983/job/24801906611?pr=41237#step:5:3055>java.lang.IllegalStateException: Failed to reset Derby database! 3055 <https://github.com/apache/arrow/actions/runs/9025730983/job/24801906611?pr=41237#step:5:3056> at org.apache.arrow.memory.core/org.apache.arrow.util.Preconditions.checkState(Preconditions.java:465) 3056 <https://github.com/apache/arrow/actions/runs/9025730983/job/24801906611?pr=41237#step:5:3057> at org.apache.arrow.flight.sql/org.apache.arrow.flight.sql.example.FlightSqlExample.<init>(FlightSqlExample.java:184) 3057 <https://github.com/apache/arrow/actions/runs/9025730983/job/24801906611?pr=41237#step:5:3058> at org.apache.arrow.flight.sql/org.apache.arrow.flight.sql.example.FlightSqlStatelessExample.<init>(FlightSqlStatelessExample.java:71) 3058 <https://github.com/apache/arrow/actions/runs/9025730983/job/24801906611?pr=41237#step:5:3059> at org.apache.arrow.flight.sql/org.apache.arrow.flight.sql.test.TestFlightSqlStateless.setUpClientServer(TestFlightSqlStateless.java:63) 3059 <https://github.com/apache/arrow/actions/runs/9025730983/job/24801906611?pr=41237#step:5:3060> at org.apache.arrow.flight.sql/org.apache.arrow.flight.sql.test.TestFlightSqlStateless.setUp(TestFlightSqlStateless.java:50) 3060 <https://github.com/apache/arrow/actions/runs/9025730983/job/24801906611?pr=41237#step:5:3061> at java.base/java.lang.reflect.Method.invoke(Method.java:566) 3061 <https://github.com/apache/arrow/actions/runs/9025730983/job/24801906611?pr=41237#step:5:3062> at java.base/java.util.ArrayList.forEach(ArrayList.java:154 On Thu, May 9, 2024 at 4:44 PM Steve Lord ***@***.***> wrote: > Thank you @mateuszrzeszutek. I have merged your changes to my PR. That > looks to successfully run. > > On Wed, May 8, 2024 at 9:48 AM Mateusz Rzeszutek ***@***.***> > wrote: > >> It looks like the ObjectPool created in FlightSqlExample's constructor >> and the dataSource are also never closed. FlightSqlExample should override >> close() to clean these up... >> >> It looks like the data source (and the object pool along with it) is >> being closed properly though: >> >> https://github.com/apache/arrow/blob/304650145689291eb87db5dd58f7b9776bdfaacf/java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/FlightSqlExample.java#L759-L767 >> >> — >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/arrow/pull/41237#issuecomment-2101000037>, or >> unsubscribe >> <https://github.com/notifications/unsubscribe-auth/ARJIX7GO2L372XBYQ3POVK3ZBJJOJAVCNFSM6AAAAABGKCCSFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGAYDAMBTG4> >> . >> You are receiving this because you were mentioned.Message ID: >> ***@***.***> >> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
