mbrobbel commented on PR #5623: URL: https://github.com/apache/arrow-rs/pull/5623#issuecomment-2107303026
> > Why would we want to avoid hashmaps/sets here? > > They're slower, given there are only 128 possibilities and they'll almost always be clustered towards the lower end, it is faster just to use a vec > Is there a benchmark? I'm wondering how much slower. > > It seems the negative type_id check was dropped. > > Would you care to expand on this? https://github.com/apache/arrow-rs/pull/5623/commits/7cd47ded5ebe01b8086ff68bcb442166a9f6f100#diff-7e118aa8aabb6fbbb2b5dcd508dd5b3219300bcb829c6cbef6cf35146320806aR191-R199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
