tustvold commented on PR #5623: URL: https://github.com/apache/arrow-rs/pull/5623#issuecomment-2107314085
The check got moved to here - https://github.com/apache/arrow-rs/pull/5623/commits/a69cbac4466eb2967ff20d6b117d30e891596f6f#diff-7e118aa8aabb6fbbb2b5dcd508dd5b3219300bcb829c6cbef6cf35146320806aR209 > Is there a benchmark? I'm wondering how much slower. No, but I would expect it to be quite significant. You are comparing the performance of a pointer indirection to a hashmap lookup. Given this check is done for every type in the array, I would expect it to be quite significant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
