zeroshade commented on code in PR #40496:
URL: https://github.com/apache/arrow/pull/40496#discussion_r1598516203
##########
go/arrow/array/dictionary.go:
##########
@@ -672,7 +672,7 @@ func NewDictionaryBuilderWithDict(mem memory.Allocator, dt
*arrow.DictionaryType
}
func NewDictionaryBuilder(mem memory.Allocator, dt *arrow.DictionaryType)
DictionaryBuilder {
- return NewDictionaryBuilderWithDict(mem, dt, nil)
+ return NewDictionaryBuilderWithDict(mem, dt, dt.Values)
Review Comment:
if you have a `RecordBuilder` then you would already have the dictionary
builder existing. In this scenario with protobuf, since we're talking about
enums, aren't we always going to have a `StringDictionaryBuilder` so you could
just do a type assertion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
