kp-tom-sc commented on code in PR #40496:
URL: https://github.com/apache/arrow/pull/40496#discussion_r1598541892
##########
go/arrow/array/dictionary.go:
##########
@@ -672,7 +672,7 @@ func NewDictionaryBuilderWithDict(mem memory.Allocator, dt
*arrow.DictionaryType
}
func NewDictionaryBuilder(mem memory.Allocator, dt *arrow.DictionaryType)
DictionaryBuilder {
- return NewDictionaryBuilderWithDict(mem, dt, nil)
+ return NewDictionaryBuilderWithDict(mem, dt, dt.Values)
Review Comment:
unfortunately not since: `array.BinaryDictionaryBuilder` does not implement
`array.DictionaryBuilder`
missing Type and the Append methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
