paleolimbot commented on code in PR #454: URL: https://github.com/apache/arrow-nanoarrow/pull/454#discussion_r1598621234
########## python/src/nanoarrow/visitor.py: ########## @@ -0,0 +1,179 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import Any, List, Sequence, Tuple, Union + +from nanoarrow._lib import CArrayView +from nanoarrow.c_array_stream import c_array_stream +from nanoarrow.iterator import ArrayViewBaseIterator, PyIterator +from nanoarrow.schema import Type + + +def to_pylist(obj, schema=None) -> List: Review Comment: Probably all the visitors and iterators would be nice in an abstract base class shared between the `Array` and `ArrayStream`! I added the user-facing bit here to ensure that `na.Array(...).to_pylist()` is what users type and if there comes a time we have to start adding documentation in multiple places (very possible with `to_columns()`) we can revisit the base class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
