paleolimbot commented on code in PR #454: URL: https://github.com/apache/arrow-nanoarrow/pull/454#discussion_r1600353033
########## python/src/nanoarrow/visitor.py: ########## @@ -0,0 +1,179 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import Any, List, Sequence, Tuple, Union + +from nanoarrow._lib import CArrayView +from nanoarrow.c_array_stream import c_array_stream +from nanoarrow.iterator import ArrayViewBaseIterator, PyIterator +from nanoarrow.schema import Type + + +def to_pylist(obj, schema=None) -> List: + """Convert ``obj`` to a ``list()` of Python objects + + Computes an identical value to ``list(iterator.iter_py())`` but is several + times faster. Review Comment: I believe that they both reuse the array_view...it seems to be `yield from` but I'm not an expert. ```python import numpy as np list_of_lists = [] for i in range(1000): list_of_lists.append(list(np.random.random(1000))) def iter_all(): for item in list_of_lists: yield from item def extend_all(): out = [] for item in list_of_lists: out.extend(item) return out assert list(iter_all()) == extend_all() %timeit list(iter_all()) #> 34.5 ms ± 522 µs per loop (mean ± std. dev. of 7 runs, 10 loops each) %timeit extend_all() #> 4.35 ms ± 517 µs per loop (mean ± std. dev. of 7 runs, 100 loops each) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
