zanmato1984 commented on code in PR #41352:
URL: https://github.com/apache/arrow/pull/41352#discussion_r1598897657
##########
cpp/src/arrow/compute/row/grouper.cc:
##########
@@ -223,12 +223,11 @@ struct AnyKeysSegmenter : public BaseRowSegmenter {
AnyKeysSegmenter(const std::vector<TypeHolder>& key_types, ExecContext* ctx)
: BaseRowSegmenter(key_types),
- ctx_(ctx),
- grouper_(nullptr),
+ grouper_(Grouper::Make(key_types, ctx).ValueOrDie()),
Review Comment:
Without extra context, there is. But the factory method (cleverly) avoids
this by a dummy instantiation of `Grouper`:
https://github.com/apache/arrow/blob/a715ea06b71ec206a987d7921264778e9954404b/cpp/src/arrow/compute/row/grouper.cc#L220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
