zanmato1984 commented on code in PR #41352:
URL: https://github.com/apache/arrow/pull/41352#discussion_r1598907898
##########
cpp/src/arrow/compute/row/grouper.cc:
##########
@@ -419,6 +414,14 @@ struct GrouperImpl : public Grouper {
return std::move(impl);
}
+ Status Reset() override {
+ map_.clear();
+ offsets_.clear();
+ key_bytes_.clear();
+ num_groups_ = 0;
Review Comment:
From what I saw in
https://github.com/apache/arrow/blob/main/cpp/src/arrow/compute/kernels/row_encoder_internal.h,
none of the encoders holds states that would change during the lifespan of the
grouper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
