birschick-bq commented on code in PR #1858:
URL: https://github.com/apache/arrow-adbc/pull/1858#discussion_r1599328165
##########
csharp/src/Drivers/Apache/Spark/SparkConnection.cs:
##########
@@ -481,8 +486,9 @@ private static IArrowType GetArrowType(ColumnTypeId
columnTypeId, string typeNam
case ColumnTypeId.CHAR_TYPE:
return StringType.Default;
case ColumnTypeId.DECIMAL_TYPE:
- // TODO: Parse typeName for precision and scale, because
not available in other metadata.
- return new Decimal128Type(38, 38);
+ // Note: parsing the type definition is only viable at the
table level. Won't
+ // work for statement results.
Review Comment:
Statement results has its own metadata. The statement's result set metadata
DOES contain precision and scale. So runtime was already working. This is only
for the `AdbcConnection.GetTableMetadata` path.
I think this comment might be misleading. What is meant to convey is that
this technique can't be used for handling complex types like ARRAY, MAP, and
STRUCT with statement results.
Might just remove the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
