jduo commented on code in PR #1858:
URL: https://github.com/apache/arrow-adbc/pull/1858#discussion_r1602056203
##########
csharp/src/Drivers/Apache/Spark/SparkConnection.cs:
##########
@@ -688,9 +693,65 @@ private string PatternToRegEx(string? pattern)
return builder.ToString();
}
+
+ /// <summary>
+ /// Provides a parser for SQL DECIMAL type definitions.
+ /// </summary>
+ private static class SqlDecimalTypeParser
+ {
+ // Pattern is based on this definition
+ //
https://docs.databricks.com/en/sql/language-manual/data-types/decimal-type.html#syntax
+ // { DECIMAL | DEC | NUMERIC } [ ( p [ , s ] ) ]
+ // p: Optional maximum precision (total number of digits) of the
number between 1 and 38. The default is 10.
+ // s: Optional scale of the number between 0 and p. The number of
digits to the right of the decimal point. The default is 0.
+ private static readonly Regex s_expression = new(
Review Comment:
Wonder, can this be const instead of static readonly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
