pitrou commented on code in PR #41352:
URL: https://github.com/apache/arrow/pull/41352#discussion_r1600165509
##########
cpp/src/arrow/acero/hash_aggregate_test.cc:
##########
@@ -592,6 +592,11 @@ void TestSegments(std::unique_ptr<RowSegmenter>&
segmenter, const ExecSpan& batc
ASSERT_EQ(expected_segment, segment);
offset = segment.offset + segment.length;
}
+ // Assert next is the last (empty) segment.
+ ASSERT_OK_AND_ASSIGN(auto segment, segmenter->GetNextSegment(batch, offset));
+ ASSERT_TRUE(segment.offset >= batch.length);
Review Comment:
Nit: use richer assertion
```suggestion
ASSERT_GE(segment.offset, batch.length);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
