zanmato1984 commented on code in PR #41125:
URL: https://github.com/apache/arrow/pull/41125#discussion_r1600418325
##########
cpp/src/arrow/acero/sorted_merge_node.cc:
##########
@@ -355,10 +358,25 @@ class SortedMergeNode : public ExecNode {
// InputState's ConcurrentQueue manages locking
input_counter[index] += rb->num_rows();
ARROW_RETURN_NOT_OK(state[index]->Push(rb));
- process_queue.Push(kNewTask);
+ PushTask(kNewTask);
return Status::OK();
}
+ void PushTask(bool bOkay) {
+#ifdef ARROW_ENABLE_THREADING
+ process_queue.Push(bOkay);
+#else
+ if (process_task.is_finished()) {
+ return;
+ }
+ if (bOkay == kNewTask) {
Review Comment:
```suggestion
void PushTask(bool ok) {
#ifdef ARROW_ENABLE_THREADING
process_queue.Push(ok);
#else
if (process_task.is_finished()) {
return;
}
if (ok == kNewTask) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
