westonpace commented on a change in pull request #9323:
URL: https://github.com/apache/arrow/pull/9323#discussion_r580559670
##########
File path: cpp/src/arrow/dataset/partition.cc
##########
@@ -410,21 +434,26 @@ std::shared_ptr<PartitioningFactory>
DirectoryPartitioning::MakeFactory(
}
util::optional<KeyValuePartitioning::Key> HivePartitioning::ParseKey(
- const std::string& segment) {
+ const std::string& segment, const std::string& null_fallback) {
auto name_end = string_view(segment).find_first_of('=');
+ // Not round-trippable
if (name_end == string_view::npos) {
return util::nullopt;
}
- return Key{segment.substr(0, name_end), segment.substr(name_end + 1)};
+ auto value = segment.substr(name_end + 1);
+ if (value == null_fallback) {
+ return Key{segment.substr(0, name_end), "", true};
+ }
+ return Key{segment.substr(0, name_end), segment.substr(name_end + 1), false};
Review comment:
Made the change (not through git since there were other changes here)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
