westonpace commented on a change in pull request #9323:
URL: https://github.com/apache/arrow/pull/9323#discussion_r580699988
##########
File path: cpp/src/arrow/compute/kernels/vector_hash.cc
##########
@@ -147,6 +152,8 @@ class ValueCountsAction final : ActionBase {
}
}
+ bool ShouldEncodeNulls() { return true; }
Review comment:
This appears to fail on GCC 6.3. See
https://github.com/apache/arrow/pull/9323/checks?check_run_id=1956850616 and
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66297
Suggestions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
