joellubi commented on code in PR #1866:
URL: https://github.com/apache/arrow-adbc/pull/1866#discussion_r1604237389
##########
go/adbc/driver/snowflake/driver_test.go:
##########
@@ -36,6 +36,7 @@ import (
"github.com/apache/arrow-adbc/go/adbc"
"github.com/apache/arrow-adbc/go/adbc/driver/internal"
+ "github.com/apache/arrow-adbc/go/adbc/driver/snowflake"
Review Comment:
Thanks @zeroshade. I had fixed that locally but have been dealing with
another issue causing tests to fail. The bufferedwriter was tripping the
checkedallocator test whereas the regular writer previously wasn't.
I was able to plug the original leak and have this all working but it will
require a separate PR to arrow which I will push up. I did slightly expand
scope here however because as a part of the testing I enabled the checked
allocator for all snowflake tests and have been chasing down a few unrelated
issues as well. I'll push up some commits so you can see exactly what I mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
