joellubi commented on code in PR #1866:
URL: https://github.com/apache/arrow-adbc/pull/1866#discussion_r1604268800
##########
go/adbc/driver/snowflake/driver_test.go:
##########
@@ -36,6 +36,7 @@ import (
"github.com/apache/arrow-adbc/go/adbc"
"github.com/apache/arrow-adbc/go/adbc/driver/internal"
+ "github.com/apache/arrow-adbc/go/adbc/driver/snowflake"
Review Comment:
Most tests should pass once
[https://github.com/apache/arrow/pull/41698](https://github.com/apache/arrow/pull/41698)
is merged and pulled in.
There is still just one test remaining with a memory leak, which is
`TestNonIntDecimalLowPrecision`. It seems rely on compute kernels to cast
decimal values to floats. This involves buffer preallocation in _some_ cases
which doesn't appear to get released properly. I haven't gotten to the bottom
of this yet but if anyone else is more familiar with it or has the time, I
could use a second set of eyes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
