zeroshade commented on code in PR #41698:
URL: https://github.com/apache/arrow/pull/41698#discussion_r1605119265


##########
go/parquet/file/page_writer.go:
##########
@@ -451,6 +451,7 @@ func (bw *bufferedPageWriter) Close(hasDict, fallback bool) 
error {
 
        buf := bw.inMemSink.Finish()
        defer buf.Release()
+       bw.inMemSink.Release()

Review Comment:
   This is interesting actually. Instead of adding this call to release, is it 
possible for us to make sure the call to `Finish()` properly releases things?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to