joellubi commented on code in PR #41698:
URL: https://github.com/apache/arrow/pull/41698#discussion_r1605262238
##########
go/parquet/file/page_writer.go:
##########
@@ -451,6 +451,7 @@ func (bw *bufferedPageWriter) Close(hasDict, fallback bool)
error {
buf := bw.inMemSink.Finish()
defer buf.Release()
+ bw.inMemSink.Release()
Review Comment:
Sounds good. I pushed up the change. I like this approach because anyone
currently using `Reset` will still get a ready to use buffer, it just won't
allocate any memory if zero bytes are requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
