vibhatha commented on code in PR #41646:
URL: https://github.com/apache/arrow/pull/41646#discussion_r1605596872


##########
java/dataset/src/main/cpp/jni_wrapper.cc:
##########
@@ -154,6 +155,21 @@ arrow::Result<std::shared_ptr<arrow::dataset::FileFormat>> 
GetFileFormat(
   }
 }
 
+arrow::Result<std::shared_ptr<arrow::dataset::FragmentScanOptions>>
+GetFragmentScanOptions(jint file_format_id,
+                       const std::unordered_map<std::string, std::string>& 
configs) {
+  switch (file_format_id) {
+#ifdef ARROW_CSV
+    case 3:
+      return arrow::dataset::CsvFragmentScanOptions::from(configs);
+#endif
+    default:
+      std::string error_message =
+          "illegal file format id: " + std::to_string(file_format_id);

Review Comment:
   nit:
   ```suggestion
             "Illegal file format id: " + std::to_string(file_format_id);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to