lidavidm commented on code in PR #41646:
URL: https://github.com/apache/arrow/pull/41646#discussion_r1609160640
##########
cpp/src/arrow/dataset/file_csv.cc:
##########
@@ -52,6 +53,9 @@ using internal::Executor;
using internal::SerialExecutor;
namespace dataset {
+namespace {
+inline bool parseBool(const std::string& value) { return value == "true" ?
true : false; }
Review Comment:
note: please follow the naming convention (UpperCamelCase functions/classes,
snake_case variable names)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]