CurtHagenlocher commented on code in PR #1870:
URL: https://github.com/apache/arrow-adbc/pull/1870#discussion_r1605813790
##########
csharp/Directory.Build.props:
##########
@@ -29,7 +29,7 @@
<Product>Apache Arrow ADBC library</Product>
<Copyright>Copyright 2022-2024 The Apache Software Foundation</Copyright>
<Company>The Apache Software Foundation</Company>
- <Version>1.0.0</Version>
+ <VersionPrefix>1.0.0</VersionPrefix>
Review Comment:
if we also add a VersionSuffix of SNAPSHOT, would that make builds from the
main branch produce versions of 1.0.0-SNAPSHOT when the version suffix is not
overridden? If so, this seems like a good change to make at the same time. It
would be consistent with a bunch of the other builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
