adamreeve commented on code in PR #41721:
URL: https://github.com/apache/arrow/pull/41721#discussion_r1607326714
##########
c_glib/arrow-glib/meson.build:
##########
@@ -205,15 +205,16 @@ cpp_internal_headers = files(
'internal-index.hpp',
)
-version_h_conf = configuration_data()
-version_h_conf.set('GARROW_VERSION_MAJOR', version_major)
-version_h_conf.set('GARROW_VERSION_MINOR', version_minor)
-version_h_conf.set('GARROW_VERSION_MICRO', version_micro)
-version_h_conf.set('GARROW_VERSION_TAG', version_tag)
-version_h = configure_file(input: 'version.h.in',
- output: 'version.h',
- configuration: version_h_conf)
-c_headers += version_h
+version_h = custom_target(
+ 'arrow-glib-version-header',
+ input: 'version.h.in',
+ output: 'version.h',
+ command: [gen_version_header, '--library', 'GARROW', '--version', version,
'--input', '@INPUT@', '--output', '@OUTPUT@'],
+ install: true,
+ install_dir: join_paths(include_dir, 'arrow-glib')
+)
+
+built_headers = [version_h]
Review Comment:
Ah actually I remember now after trying to change this back, I got an error
like this when the version header was used as an input to mkenums:
```
ninja: error: '/home/adam/dev/arrow/build/c_glib/arrow-glib/version.h',
needed by 'arrow-glib/enums.h', missing and no known rule to make it
```
I'll see if I can make this work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
