kou commented on code in PR #41721:
URL: https://github.com/apache/arrow/pull/41721#discussion_r1608942594
##########
dev/release/utils-prepare.sh:
##########
@@ -40,6 +40,15 @@ update_versions() {
meson.build
rm -f meson.build.bak
git add meson.build
+
+ glib_version_tuple="(${major_version}, 0)"
+ if [ "${type}" = "snapshot" ] && ! grep -q "${glib_version_tuple}"
tool/generate-version-header.py; then
Review Comment:
Ah, I see. How about this?
```diff
diff --git a/dev/release/utils-prepare.sh b/dev/release/utils-prepare.sh
index e4b12dad0a..d6891ad422 100644
--- a/dev/release/utils-prepare.sh
+++ b/dev/release/utils-prepare.sh
@@ -41,8 +41,11 @@ update_versions() {
rm -f meson.build.bak
git add meson.build
- glib_version_tuple="(${major_version}, 0)"
- if [ "${type}" = "snapshot" ] && ! grep -q "${glib_version_tuple}"
tool/generate-version-header.py; then
+ # Add a new major version entry only when the next release is a new
+ # major release
+ if [ "${type}" = "snapshot" -a \
+ "${next_version}" = "${major_version}.0.0" ] ; then
+ local glib_version_tuple="(${major_version}, 0)"
sed -i.bak -E -e \
"s/^ALL_VERSIONS = \[$/&\\n ${glib_version_tuple},/" \
tool/generate-version-header.py
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
