joellubi commented on code in PR #1866:
URL: https://github.com/apache/arrow-adbc/pull/1866#discussion_r1608540315
##########
go/adbc/driver/snowflake/driver_test.go:
##########
@@ -325,31 +325,26 @@ type SnowflakeTests struct {
stmt adbc.Statement
}
-func (suite *SnowflakeTests) SetupSuite() {
+func (suite *SnowflakeTests) SetupTest() {
Review Comment:
This allows all tests to use the SetupDriver and TeardownDriver methods
defined on the DriverQuirks. This came to my attention because only the tests
in `validation.go` which were using Setup/TeardownDriver caught the memory
leak. This allows us to have the same test setup for the driver tests as well.
Without this, the driver was getting created with one checked allocator and
each test would create another one, preventing a full view of memory
allocations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
