mapleFU commented on code in PR #41801:
URL: https://github.com/apache/arrow/pull/41801#discussion_r1612026246
##########
cpp/src/arrow/filesystem/gcsfs.cc:
##########
@@ -284,6 +287,9 @@ class GcsRandomAccessFile : public
arrow::io::RandomAccessFile {
Result<std::shared_ptr<const KeyValueMetadata>> ReadMetadata() override {
return internal::FromObjectMetadata(metadata_);
}
+ int64_t preferred_read_size(std::optional<int64_t> nbytes) const override {
+ return kPreferredReadSize;
Review Comment:
Should a `max()` being provided?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
