pitrou commented on code in PR #41801:
URL: https://github.com/apache/arrow/pull/41801#discussion_r1612026131
##########
cpp/src/arrow/io/interfaces.cc:
##########
@@ -115,6 +115,13 @@ Result<std::string_view> InputStream::Peek(int64_t
ARROW_ARG_UNUSED(nbytes)) {
bool InputStream::supports_zero_copy() const { return false; }
+int64_t InputStream::preferred_read_size(std::optional<int64_t> nbytes) const {
+ if (nbytes.has_value()) {
+ return nbytes.value();
+ }
+ return 16 << 10; // 16 kiB, arbitrary value
Review Comment:
Why 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
