kou commented on code in PR #41837:
URL: https://github.com/apache/arrow/pull/41837#discussion_r1615414913
##########
java/dataset/src/main/cpp/jni_wrapper.cc:
##########
@@ -27,7 +27,9 @@
#include "arrow/dataset/file_base.h"
#include "arrow/filesystem/localfs.h"
#include "arrow/filesystem/path_util.h"
+#ifdef ARROW_S3
Review Comment:
OK. How about the following?
```diff
diff --git a/java/dataset/src/main/cpp/jni_wrapper.cc
b/java/dataset/src/main/cpp/jni_wrapper.cc
index 19a43c8d2f..f1819aab0b 100644
--- a/java/dataset/src/main/cpp/jni_wrapper.cc
+++ b/java/dataset/src/main/cpp/jni_wrapper.cc
@@ -25,9 +25,8 @@
#include "arrow/c/helpers.h"
#include "arrow/dataset/api.h"
#include "arrow/dataset/file_base.h"
-#include "arrow/filesystem/localfs.h"
+#include "arrow/filesystem/api.h"
#include "arrow/filesystem/path_util.h"
-#include "arrow/filesystem/s3fs.h"
#include "arrow/engine/substrait/util.h"
#include "arrow/engine/substrait/serde.h"
#include "arrow/engine/substrait/relation.h"
```
`arrow/filesystem/api.h` includes `arrow/util/config.h` explicitly and
`ARROW_S3` must be defined if S3 is enabled with `arrow/filesystem/api.h`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
