PHILO-HE commented on code in PR #41837: URL: https://github.com/apache/arrow/pull/41837#discussion_r1615434993
########## java/dataset/src/main/cpp/jni_wrapper.cc: ########## @@ -27,7 +27,9 @@ #include "arrow/dataset/file_base.h" #include "arrow/filesystem/localfs.h" #include "arrow/filesystem/path_util.h" +#ifdef ARROW_S3 Review Comment: @kou, by including [arrow/filesystem/api.h](https://github.com/apache/arrow/blob/main/cpp/src/arrow/filesystem/api.h), a few extra headers are directly or indirectly included, but they are not actually used here. Can we just keep the current change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
