adamreeve opened a new pull request, #41839:
URL: https://github.com/apache/arrow/pull/41839

   ### Rationale for this change
   
   This is more consistent as vcpkg is now used for both the Arrow C++ 
dependencies and GLib library dependencies, and also fixes building 
arrow-flight-glib and arrow-flight-sql-glib which previously failed due to a 
missing zlib dependency.
   
   ### What changes are included in this PR?
   
   * Configure the MSVC GLib build to use VCPKG as the dependency source for 
the C++ build
   * Configure GitHub packages based vcpkg caching (see 
https://learn.microsoft.com/en-us/vcpkg/users/binarycaching#quickstart-github)
   * Enable building Flight and Flight SQL
   
   ### Are these changes tested?
   
   NA
   
   ### Are there any user-facing changes?
   
   No
   
   Because GitHub packages is being used for caching, this will start creating 
GitHub packages that are visible in the main page of the Arrow GitHub 
repository by default. Eg. you can see them in the right panel on the crossbow 
repo which also runs tasks that use GitHub packages for vcpkg caching: 
https://github.com/ursacomputing/crossbow.
   
   The Arrow repository doesn't currently publish any packages, so it would 
probably be best to hide these by default to avoid confusing users and adding 
unnecessary noise. Someone with admin privileges on the Arrow GitHub repository 
would need to click the cog on the home page and hide this section:
   
![hide_packages](https://github.com/apache/arrow/assets/626438/69e1be77-65e7-4a17-8e9e-6d7cf90834b5)
   
   If this isn't desirable I could look into other ways of caching instead, eg. 
using a file based cache combined with GitHub actions cache action, or the 
experimental GitHub actions cache in vcpkg.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to