kou commented on code in PR #41839:
URL: https://github.com/apache/arrow/pull/41839#discussion_r1615444868
##########
.github/workflows/ruby.yml:
##########
@@ -387,11 +392,28 @@ jobs:
env:
# We can invalidate the current cache by updating this.
CACHE_VERSION: "2024-05-09"
+ - name: Setup NuGet credentials for vcpkg caching
+ shell: bash
+ run: |
+ `./vcpkg/vcpkg.exe fetch nuget | tail -n 1` \
Review Comment:
```suggestion
$(vcpkg/vcpkg.exe fetch nuget | tail -n 1) \
```
##########
cpp/cmake_modules/Usevcpkg.cmake:
##########
@@ -249,4 +249,7 @@ if(CMAKE_HOST_WIN32)
set(ZSTD_MSVC_STATIC_LIB_SUFFIX
""
CACHE STRING "")
+ set(utf8proc_MSVC_STATIC_LIB_SUFFIX
+ ""
+ CACHE STRING "")
Review Comment:
Could you keep this list in alphabetical order?
##########
.github/workflows/ruby.yml:
##########
@@ -387,11 +392,28 @@ jobs:
env:
# We can invalidate the current cache by updating this.
CACHE_VERSION: "2024-05-09"
+ - name: Setup NuGet credentials for vcpkg caching
+ shell: bash
+ run: |
+ `./vcpkg/vcpkg.exe fetch nuget | tail -n 1` \
+ sources add \
+ -source
"https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json"; \
+ -storepasswordincleartext \
+ -name "GitHub" \
+ -username "$GITHUB_REPOSITORY_OWNER" \
+ -password "${{ secrets.GITHUB_TOKEN }}"
+ `./vcpkg/vcpkg.exe fetch nuget | tail -n 1` \
+ setapikey "${{ secrets.GITHUB_TOKEN }}" \
+ -source
"https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json";
+ - name: Build C++ VCPKG dependencies
+ shell: cmd
+ run: |
+ vcpkg\vcpkg.exe install --triplet x64-windows --x-manifest-root cpp
--x-install-root build\cpp\vcpkg_installed
- name: Build C++
shell: cmd
run: |
call "C:\Program Files (x86)\Microsoft Visual
Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
- bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build"
+ bash -c "VCPKG_ROOT=\"$(pwd)/vcpkg\" ci/scripts/cpp_build.sh $(pwd)
$(pwd)/build"
Review Comment:
Can we set this in `env:` something like `VCPKG_ROOT: "${{ github.workspace
}}/vcpkg"`?
(Do we need UNIX style path here?)
##########
.github/workflows/ruby.yml:
##########
@@ -387,11 +392,28 @@ jobs:
env:
# We can invalidate the current cache by updating this.
CACHE_VERSION: "2024-05-09"
+ - name: Setup NuGet credentials for vcpkg caching
+ shell: bash
+ run: |
+ `./vcpkg/vcpkg.exe fetch nuget | tail -n 1` \
+ sources add \
+ -source
"https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json"; \
+ -storepasswordincleartext \
+ -name "GitHub" \
+ -username "$GITHUB_REPOSITORY_OWNER" \
+ -password "${{ secrets.GITHUB_TOKEN }}"
+ `./vcpkg/vcpkg.exe fetch nuget | tail -n 1` \
Review Comment:
```suggestion
$(vcpkg/vcpkg.exe fetch nuget | tail -n 1) \
```
##########
.github/workflows/ruby.yml:
##########
@@ -337,13 +340,15 @@ jobs:
ARROW_WITH_LZ4: OFF
ARROW_WITH_OPENTELEMETRY: OFF
ARROW_WITH_SNAPPY: ON
- ARROW_WITH_ZLIB: OFF
+ ARROW_WITH_ZLIB: ON
ARROW_WITH_ZSTD: ON
BOOST_SOURCE: BUNDLED
Review Comment:
Can we remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
