wgtmac commented on code in PR #41819:
URL: https://github.com/apache/arrow/pull/41819#discussion_r1615992876
##########
cpp/src/parquet/encoding.cc:
##########
@@ -442,12 +442,12 @@ class DictEncoderImpl : public EncoderImpl, virtual
public DictEncoder<DType> {
constexpr static int32_t kDataPageBitWidthBytes = 1;
explicit DictEncoderImpl(const ColumnDescriptor* desc, MemoryPool* pool)
- : EncoderImpl(desc, Encoding::PLAIN_DICTIONARY, pool),
+ : EncoderImpl(desc, Encoding::RLE_DICTIONARY, pool),
Review Comment:
Yes, but it wrote 2 (PLAIN_DICTIONARY) in the past and now 8
(RLE_DICTIONARY) for the dict indices which may not be recognized by legacy
readers (though unlikely).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
