pitrou commented on code in PR #41819:
URL: https://github.com/apache/arrow/pull/41819#discussion_r1616177263
##########
cpp/src/parquet/types.h:
##########
@@ -811,4 +811,10 @@ PARQUET_EXPORT SortOrder::type
GetSortOrder(ConvertedType::type converted,
PARQUET_EXPORT SortOrder::type GetSortOrder(
const std::shared_ptr<const LogicalType>& logical_type, Type::type
primitive);
+/// PLAIN_DICTIONARY is deprecated but used to be used as a dictionary index
+/// encoding.
Review Comment:
Please make sure the docstring explains what the function does.
If you want to explain implementation details, regular comments (`//`)
should be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
