jorisvandenbossche commented on code in PR #41041:
URL: https://github.com/apache/arrow/pull/41041#discussion_r1618826411
##########
python/examples/minimal_build/build_venv.sh:
##########
@@ -68,11 +69,9 @@ export
CMAKE_PREFIX_PATH=${ARROW_HOME}${CMAKE_PREFIX_PATH:+:${CMAKE_PREFIX_PATH}
export PYARROW_BUILD_TYPE=Debug
export PYARROW_CMAKE_GENERATOR=Ninja
-# You can run either "develop" or "build_ext --inplace". Your pick
-
-# python setup.py build_ext --inplace
-python setup.py develop
+# Use the same command that we use on python_build.sh
+python -m pip install --no-deps --no-build-isolation -e .
Review Comment:
Do you know why the `-e` is needed if then below we actually run tests
against installed package? (now, we did install it in editable mode before as
well, so fine to just keep this, just wondering why the change to `--pyargs
pyarrow` below if we keep this editable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
