raulcd commented on code in PR #41041:
URL: https://github.com/apache/arrow/pull/41041#discussion_r1618836868


##########
python/examples/minimal_build/build_venv.sh:
##########
@@ -68,11 +69,9 @@ export 
CMAKE_PREFIX_PATH=${ARROW_HOME}${CMAKE_PREFIX_PATH:+:${CMAKE_PREFIX_PATH}
 export PYARROW_BUILD_TYPE=Debug
 export PYARROW_CMAKE_GENERATOR=Ninja
 
-# You can run either "develop" or "build_ext --inplace". Your pick
-
-# python setup.py build_ext --inplace
-python setup.py develop
+# Use the same command that we use on python_build.sh
+python -m pip install --no-deps --no-build-isolation -e .

Review Comment:
   I am not sure why the editable mode is required but otherwise it fails 
importing `pyarrow.lib`. I have been able to validate on my local build tree 
that without the editable mode the cython compiled files aren't available 
there, I should investigate further. Those files aren't there without it, I 
should investigate where are those being installed because they are being 
generated:
   ```
   python/pyarrow/lib.cpython-310-x86_64-linux-gnu.so
   python/pyarrow/lib.cpython-38-x86_64-linux-gnu.so
   ```
   as per the `--pyargs pyarrow` I just copied the same command we use for 
testing on `python_test.sh` when I was debugging, I can probably revert back 
this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to