kou commented on code in PR #41872:
URL: https://github.com/apache/arrow/pull/41872#discussion_r1619460671
##########
cpp/src/arrow/util/decimal.cc:
##########
@@ -799,7 +800,7 @@ Status Decimal128::ToArrowStatus(DecimalStatus dstatus)
const {
return arrow::ToArrowStatus(dstatus, 128);
}
-std::ostream& operator<<(std::ostream& os, const Decimal128& decimal) {
+ARROW_EXPORT std::ostream& operator<<(std::ostream& os, const Decimal128&
decimal) {
Review Comment:
Can we avoid using `ARROW_EXPORT` in `.cc`?
Does this work instead of adding `ARROW_EXPORT` in `.cc`?
```diff
diff --git a/cpp/src/arrow/util/visibility.h
b/cpp/src/arrow/util/visibility.h
index 1498d2085a..bad80dd8a2 100644
--- a/cpp/src/arrow/util/visibility.h
+++ b/cpp/src/arrow/util/visibility.h
@@ -77,8 +77,8 @@
#endif
#endif
-#define ARROW_FRIEND_EXPORT
-#define ARROW_TEMPLATE_EXPORT
+#define ARROW_FRIEND_EXPORT ARROW_EXPORT
+#define ARROW_TEMPLATE_EXPORT ARROW_EXPORT
// [[gnu::visibility("default")]] even when #included by a non-arrow source
#define ARROW_FORCE_EXPORT [[gnu::visibility("default")]]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
