WillAyd commented on code in PR #41872:
URL: https://github.com/apache/arrow/pull/41872#discussion_r1620851622
##########
cpp/src/arrow/util/decimal.cc:
##########
@@ -799,7 +800,7 @@ Status Decimal128::ToArrowStatus(DecimalStatus dstatus)
const {
return arrow::ToArrowStatus(dstatus, 128);
}
-std::ostream& operator<<(std::ostream& os, const Decimal128& decimal) {
+ARROW_EXPORT std::ostream& operator<<(std::ostream& os, const Decimal128&
decimal) {
Review Comment:
Doesn't look like clang nor gcc 12 onwards will like that. From what I
understand, putting the attribute next to a friend declaration won't work - it
needs to be attached to the definition:
https://stackoverflow.com/a/52332379/621736
Should I move the definition into the header file or should we revert back
to the original design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
