lidavidm commented on code in PR #41895:
URL: https://github.com/apache/arrow/pull/41895#discussion_r1621534234
##########
java/dataset/pom.xml:
##########
@@ -150,6 +150,12 @@
<version>2.15.1</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest</artifactId>
+ <version>2.2</version>
Review Comment:
Can we set the version in dependencyManagement at the root level? I believe
a few other modules use hamcrest too.
##########
java/vector/src/main/java/org/apache/arrow/vector/util/ValueVectorUtility.java:
##########
Review Comment:
I suppose eventually we can add typed/generic versions? (I suppose we'd have
to write out overloads per class so that `IntVector` returns
`Iterator<Integer>` etc. Or else accept `Class<T>` and assert at runtime that
the vector is of the right type.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
