normanj-bitquill commented on code in PR #41895: URL: https://github.com/apache/arrow/pull/41895#discussion_r1622919117
########## java/vector/src/main/java/org/apache/arrow/vector/util/ValueVectorUtility.java: ########## Review Comment: @lidavidm We can. I view this as functionality that is meant to only be used by the unit tests. It could be enhanced to support the Iterator type matching the ValueVector type. For that I would favour adding the type information to the ValueVector classes and using that to determine the type of the Iterator. The `Iterator` and `Iterable` are publicly available. Is there anything more that can be done to discourage their use in Arrow applications? Are you looking for properly typed `Iterator`s in this PR or should that wait for a future PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
