cocoa-xu commented on code in PR #499:
URL: https://github.com/apache/arrow-nanoarrow/pull/499#discussion_r1622194333
##########
src/nanoarrow/array_test.cc:
##########
@@ -787,6 +787,43 @@ TEST(ArrayTest, ArrayTestAppendToFloatArray) {
EXPECT_TRUE(arrow_array.ValueUnsafe()->Equals(expected_array.ValueUnsafe(),
options));
}
+TEST(ArrayTest, ArrayTestAppendToHalfFloatArray) {
+ struct ArrowArray array;
+
+ ASSERT_EQ(ArrowArrayInitFromType(&array, NANOARROW_TYPE_HALF_FLOAT),
NANOARROW_OK);
+ EXPECT_EQ(ArrowArrayStartAppending(&array), NANOARROW_OK);
+ EXPECT_EQ(ArrowArrayAppendInt(&array, 1), NANOARROW_OK);
+ EXPECT_EQ(ArrowArrayAppendNull(&array, 2), NANOARROW_OK);
+ EXPECT_EQ(ArrowArrayAppendUInt(&array, 3), NANOARROW_OK);
+ EXPECT_EQ(ArrowArrayAppendDouble(&array, 3.14), NANOARROW_OK);
+ EXPECT_EQ(ArrowArrayAppendDouble(&array, std::numeric_limits<float>::max()),
+ NANOARROW_OK);
+ EXPECT_EQ(ArrowArrayAppendDouble(&array, NAN), NANOARROW_OK);
+ EXPECT_EQ(ArrowArrayAppendDouble(&array, INFINITY), NANOARROW_OK);
+ EXPECT_EQ(ArrowArrayAppendDouble(&array, -INFINITY), NANOARROW_OK);
+ EXPECT_EQ(ArrowArrayAppendDouble(&array, -1), NANOARROW_OK);
+ EXPECT_EQ(ArrowArrayAppendDouble(&array, 0), NANOARROW_OK);
+ EXPECT_EQ(ArrowArrayFinishBuildingDefault(&array, nullptr), NANOARROW_OK);
+
+ EXPECT_EQ(array.length, 11);
+ EXPECT_EQ(array.null_count, 2);
+ auto validity_buffer = reinterpret_cast<const uint8_t*>(array.buffers[0]);
+ auto data_buffer = reinterpret_cast<const uint16_t*>(array.buffers[1]);
+ EXPECT_EQ(validity_buffer[0], 0b11111001);
+ EXPECT_EQ(validity_buffer[1], 0b00000111);
+ EXPECT_EQ(data_buffer[0], 15360);
+ EXPECT_EQ(data_buffer[1], 0);
+ EXPECT_EQ(data_buffer[2], 0);
+ EXPECT_EQ(data_buffer[3], 16896);
+ EXPECT_EQ(data_buffer[4], 16967);
+ EXPECT_EQ(data_buffer[5], 31744);
+ EXPECT_EQ(data_buffer[6], 32256);
+ EXPECT_EQ(data_buffer[7], 31744);
+ EXPECT_EQ(data_buffer[8], 64512);
+ EXPECT_EQ(data_buffer[9], 48128);
+ EXPECT_EQ(data_buffer[10], 0);
Review Comment:
Oh I see. Maybe we can use the Go implementation to generate some test cases
if needed? (And in the most unlikely event that the Go implementation for
float16 is wrong, we still would have the same encoding and decoding function
and compatible with arrow-go.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
