aosingh commented on code in PR #502:
URL: https://github.com/apache/arrow-nanoarrow/pull/502#discussion_r1623152444
##########
python/src/nanoarrow/c_array.py:
##########
@@ -549,6 +549,9 @@ def _append_using_buffer_builder(self, obj: Iterable) ->
None:
CArrowType.UINT64: "_append_using_array",
CArrowType.FLOAT: "_append_using_array",
CArrowType.DOUBLE: "_append_using_array",
+ CArrowType.TIMESTAMP: "_append_using_array",
+ CArrowType.DATE32: "_append_using_array",
+ CArrowType.DATE64: "_append_using_array"
Review Comment:
Yes, I think we can include Duration too. Let me add it and some tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
