paleolimbot commented on code in PR #502:
URL: https://github.com/apache/arrow-nanoarrow/pull/502#discussion_r1625157773
##########
python/src/nanoarrow/_lib.pyx:
##########
@@ -1069,6 +1069,12 @@ cdef class CSchemaView:
NANOARROW_TYPE_SPARSE_UNION
)
+ _buffer_protocol_supported_types = (
+ NANOARROW_TYPE_DATE32,
+ NANOARROW_TYPE_DATE64,
+ NANOARROW_TYPE_TIMESTAMP
+ )
Review Comment:
It's a great question (and should be better documented): `buffer_format` is
for when a Python buffer protocol format string/struct module format string is
sufficient to describe a type. `storage_buffer_format` would also include types
whose underlying data has a valid format string (but that have extra logical
type interpretation that is not captured solely by the format string).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
