adamreeve commented on PR #41886: URL: https://github.com/apache/arrow/pull/41886#issuecomment-2143759677
Thanks for the thorough feedback @kou! I will follow up on all of these points but it might take a while. > It makes sense. > We already have CI jobs that use the approach: I meant that storing the .gir files checked in to git doesn't make sense, not that merging outputs from different platforms didn't make sense. It's helpful to see some examples of this though thank you. I guess we could store the .gir files in git to simplify local development but it seems redundant and we'd need checks to ensure they're kept updated so would still need to build them in CI anyway. > I think this is caused by Arrow -> Apache.Arrow.GLibBindings namespace substitution by sed. > Can we hide symbols generated by Gir.Core instead of renaming? Yes you're correct, I debugged this issue and found that it failed to match the types with their references due to the namespaces not matching (in https://github.com/gircore/gir.core/blob/ca3866730435b989e73ce2a9a05a81386ce9e332/src/Generation/GirLoader/Output/Class.cs#L49). I don't think there's an easy way to keep the same names and hide the generated symbols but I'll have a look into this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
