paleolimbot commented on PR #505: URL: https://github.com/apache/arrow-nanoarrow/pull/505#issuecomment-2147422708
> setuptools, which is the historical builder / packager / installer for Python but has fallen out of favor for more specialized tools This is good to know (my Python is not very idiomatic and was mostly learned 8ish years ago). I will point out that because setuptools has been supported since the dawn of time on every platform where there is a Python, it makes it trivial to support installation everywhere (which is sort of nanoarrow's mantra). Setuptools makes it difficult to incorporate non-system dependencies (which is where meson and cmake shine for building Python extensions), but we don't have any dependencies we can't vendor (and never will). I suppose the gist of this PR is that it removes the vendoring of nanoarrow and turns it into a dependency; however, I'm not sure we want that either (also sort of nice to be able to distribute a self-contained source distribution that can be installed offline). The one thing I don't like about the bootstrap + vendor method is that in a debugger the source references are all to the bundled nanoarrow.c, so it's a tiny bit of extra work to find + fix the error in the actual C sources (luckily that doesn't happen very often 🙂 ). It seems like the example from the bottom of the wrap file accomplishes that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
