WillAyd commented on PR #505: URL: https://github.com/apache/arrow-nanoarrow/pull/505#issuecomment-2147724343
Yea this can't pass CI until #483 and #484 happen, so could also defer reviewing until that point in time On a second read just want to point out that: > I suppose the gist of this PR is that it removes the vendoring of nanoarrow and turns it into a dependency; Doesn't really change with this. Python doesn't have robust dependency management like that. This just makes it easier to build from source as meson would handle downloading the library for you, but when a wheel gets created it would still copy the necessary nanoarrow library from the source structure (i.e. subprojects for Meson) and into the wheel I actually think this still might check all the boxes but lets defer until we can get CI green to review again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
