alamb commented on code in PR #5856:
URL: https://github.com/apache/arrow-rs/pull/5856#discussion_r1631819198
##########
parquet/src/column/page.rs:
##########
@@ -37,7 +37,7 @@ pub enum Page {
encoding: Encoding,
def_level_encoding: Encoding,
rep_level_encoding: Encoding,
- statistics: Option<Statistics>,
+ statistics: Option<Box<Statistics>>,
Review Comment:
Is the idea is that doing this reduces allocation size when no statistics
are present? I would actually think in the case where there are page statistics
this might actually slow things down due to the indirection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
