XiangpengHao commented on code in PR #5856:
URL: https://github.com/apache/arrow-rs/pull/5856#discussion_r1631832588
##########
parquet/src/column/page.rs:
##########
@@ -37,7 +37,7 @@ pub enum Page {
encoding: Encoding,
def_level_encoding: Encoding,
rep_level_encoding: Encoding,
- statistics: Option<Statistics>,
+ statistics: Option<Box<Statistics>>,
Review Comment:
Yes, for none stats, this is pure improvement; but for page stats, this is a
trade-off: extra allocation vs smaller stack movement, in the blog post's
Figure 7 (+layout opt), we can see that smaller stack movement wins and the
improvement is indeed smaller for page/chunk stats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
