llama90 commented on code in PR #42038:
URL: https://github.com/apache/arrow/pull/42038#discussion_r1632070214
##########
java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/AbstractJdbcToArrowTest.java:
##########
@@ -91,15 +89,15 @@ protected static Table getTable(String ymlFilePath,
@SuppressWarnings("rawtypes"
clss.getClassLoader().getResourceAsStream(ymlFilePath),
Table.class);
}
-
/**
* This method creates Connection object and DB table and also populate data
into table for test.
*
* @throws SQLException on error
* @throws ClassNotFoundException on error
*/
- @Before
- public void setUp() throws SQLException, ClassNotFoundException {
+ protected void initializeDatabase(Table table) throws SQLException,
ClassNotFoundException {
Review Comment:
@vibhatha I'll look into it more, but if you have any suggestions for a
better structure, I would really appreciate your advice.
cc @lidavidm
```mermaid
classDiagram
direction LR
class AbstractJdbcToArrowTest {
}
class JdbcToArrowCharSetTest {
}
class JdbcToArrowDataTypesTest {
}
class JdbcToArrowMapDataTypeTest {
}
class JdbcToArrowNullTest {
}
class JdbcToArrowOptionalColumnsTest {
}
class JdbcToArrowTest {
}
class JdbcToArrowTimeZoneTest {
}
class JdbcToArrowVectorIteratorTest {
}
AbstractJdbcToArrowTest <|-- JdbcToArrowCharSetTest
AbstractJdbcToArrowTest <|-- JdbcToArrowDataTypesTest
AbstractJdbcToArrowTest <|-- JdbcToArrowMapDataTypeTest
AbstractJdbcToArrowTest <|-- JdbcToArrowNullTest
AbstractJdbcToArrowTest <|-- JdbcToArrowOptionalColumnsTest
AbstractJdbcToArrowTest <|-- JdbcToArrowTest
AbstractJdbcToArrowTest <|-- JdbcToArrowTimeZoneTest
JdbcToArrowTest <|-- JdbcToArrowVectorIteratorTest
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
