lidavidm commented on code in PR #42038:
URL: https://github.com/apache/arrow/pull/42038#discussion_r1635852451
##########
java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/AbstractJdbcToArrowTest.java:
##########
@@ -91,15 +89,15 @@ protected static Table getTable(String ymlFilePath,
@SuppressWarnings("rawtypes"
clss.getClassLoader().getResourceAsStream(ymlFilePath),
Table.class);
}
-
/**
* This method creates Connection object and DB table and also populate data
into table for test.
*
* @throws SQLException on error
* @throws ClassNotFoundException on error
*/
- @Before
- public void setUp() throws SQLException, ClassNotFoundException {
+ protected void initializeDatabase(Table table) throws SQLException,
ClassNotFoundException {
Review Comment:
I think this is fine
##########
java/bom/pom.xml:
##########
@@ -177,6 +185,10 @@
<artifactId>spotless-maven-plugin</artifactId>
<configuration>
<pom>
+ <licenseHeader>
+
<file>${maven.multiModuleProjectDirectory}/dev/license/asf-xml.license</file>
+ <delimiter>(<configuration|<project)</delimiter>
+ </licenseHeader>
Review Comment:
Where did this come from?
##########
java/bom/pom.xml:
##########
@@ -177,6 +185,10 @@
<artifactId>spotless-maven-plugin</artifactId>
<configuration>
<pom>
+ <licenseHeader>
+
<file>${maven.multiModuleProjectDirectory}/dev/license/asf-xml.license</file>
+ <delimiter>(<configuration|<project)</delimiter>
+ </licenseHeader>
Review Comment:
Oh, maybe this is a merge artifact...it seems to already be on main?
##########
java/adapter/avro/src/test/java/org/apache/arrow/adapter/avro/AvroTestBase.java:
##########
@@ -45,18 +45,17 @@
import org.apache.avro.io.DatumWriter;
import org.apache.avro.io.DecoderFactory;
import org.apache.avro.io.EncoderFactory;
-import org.junit.Before;
-import org.junit.ClassRule;
-import org.junit.rules.TemporaryFolder;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.io.TempDir;
public class AvroTestBase {
- @ClassRule
- public static final TemporaryFolder TMP = new TemporaryFolder();
+ @TempDir
+ public File TMP;
Review Comment:
The new JUnit API is different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
